0.4.0 release #113
Merged
0.4.0 release #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanRook
suggested changes
Sep 24, 2019
README.md
Outdated
| @@ -36,8 +38,11 @@ The two major use cases for this library are: | |||
| Defaults to all geometry types. | |||
| - `options.dedup` **[String](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** perform deduplication of features based on shared layers, geometry, IDs and matching | |||
| properties. (optional, default `true`) | |||
| - `options.basic-filters` **[Array](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array)<[String](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String), [Array](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array)>?** and expression-like filter out Number or Boolean properties based on | |||
| the following condtions: `=, !=, <, <=, >, >=`. The first item must be the value "any" or "all" whether any or all filters | |||
There was a problem hiding this comment.
Slight phrasing change -
an expression-like filter to include features with Numeric or Boolean properties that match the filters based on the following conditions:
Or something similar, I was having trouble parsing 'and expression-like filter out'
There was a problem hiding this comment.
Good catch. Used your phrasing 👍
CyanRook
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from #109
cc @CyanRook for review